Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rss.cy and signup.cy to Playwright #2907

Open
wants to merge 14 commits into
base: staging
Choose a base branch
from
Open

Migrate rss.cy and signup.cy to Playwright #2907

wants to merge 14 commits into from

Conversation

clari182
Copy link
Collaborator

@codecov Codecov
Copy link

codecov bot commented Jun 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (a7afcc2) to head (a8045eb).

Additional details and impacted files 
@@             Coverage Diff             @@
##           staging    #2907      +/-   ##
===========================================
+ Coverage    86.98%   94.58%   +7.60%     
===========================================
  Files          155      102      -53     
  Lines        13070    11218    -1852     
  Branches      1267      619     -648     
===========================================
- Hits         11369    10611     -758     
+ Misses        1530      587     -943     
+ Partials       171       20     -151

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Jun 24, 2024 •
edited
Loading

6 failed tests on run #2854 ↗︎

6 209 18 0 Flakiness 0

Details:

Migrate rss.cy and signup.cy to Playwright
Project: aiid-site Commit: 1aa0909b64
Status: Failed Duration: 09:51 💡
Started: Jun 26, 2024 4:43 PM Ended: Jun 26, 2024 4:53 PM
Failed  classificationsEditor.cy.js • 4 failed tests • Cypress e2e tests

View Output

Test Artifacts
Classifications Editor > Should show classifications editor on report page and add a new classification Test Replay
Classifications Editor > Should properly display and store CSETv0 classification values Test Replay
Classifications Editor > Should properly display and store GMF classification values Test Replay
Classifications Editor > Should properly display and store CSETv1 classification values Test Replay
Failed  account.cy.js • 2 failed tests • Cypress e2e tests

View Output

Test Artifacts
Account > Should allow editing user data Test Replay
Account > Should show edit modal if query parameter is is set Test Replay

Review all test suite changes for PR #2907 ↗︎

@clari182
Copy link
Collaborator Author

@cesarvarela done, ready for new review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarvarela cesarvarela Awaiting requested review from cesarvarela

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clari182 @cesarvarela